Show notification for uninstalled but synchronized extensions#7350
Show notification for uninstalled but synchronized extensions#7350jhejlsberg wants to merge 16 commits intomainfrom
Conversation
|
Issue #616423 is not valid. Please make sure you link an issue that exists, is open and is approved. |
|
@microsoft-github-policy-service agree company="Microsoft" |
…res/616423/Notify-About-Uninstalled-Extensions
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- Extension-Management: 0% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
| ActionsEnabled := false; | ||
|
|
||
| HelpActionVisible := false; | ||
| ShowUninstalledExtensionsNotification(); |
There was a problem hiding this comment.
Are we sure we want to be showing this every time the page is opened? There are legitimate reasons to have orphaned data since it is restored if the original extension is re-installed. Ideally there would be a way to mark orphaned data as "expected" and only show this if there are any new items, otherwise I can see this notification being ignored.
Also double check that the orphaned data page has some warning that if the data is deleted, it won't be restored when the extension is re-installed.
There was a problem hiding this comment.
I have double checked the latter, and there is a pop-up opened when you select delete for a given uninstalled extension with a warning that this action can not be undone.
The purpose of the banner is simply to draw attention to orphaned data. It's quite minimal, so showing it on page open shouldn't be disruptive.
I agree that if extension data was intentionally kept for a later restore, it would be nicer to suppress the banner but I don't see this as a significant issue. But if you think it is worth implementing let me know and I will add it.
There was a problem hiding this comment.
I think it's worth it, otherwise the moment you have a single uninstalled extension whose data you want to keep, this notification becomes useless since there's no way to distinguish from the data you want to keep from what you might want to clean up.
|
…res/616423/Notify-About-Uninstalled-Extensions
…y-About-Uninstalled-Extensions
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- Extension-Management: 0% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
…y-About-Uninstalled-Extensions
There was a problem hiding this comment.
Pull request overview
Adds a user-facing notification on the Extension Management page to surface orphaned extension data (uninstalled extensions with synchronized data still present) and provides navigation/actions to review or suppress future notifications.
Changes:
- Show a notification on opening Extension Management when unreviewed orphaned extension data exists.
- Add notification actions to open Delete Orphaned Extension Data and to mark all orphaned data as reviewed.
- Extend Delete Orphaned Extension Data page with an Is Reviewed column and a Mark All as Reviewed action.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/System Application/App/Extension Management/src/ExtensionOperationImpl.Codeunit.al | Adds notification action handlers to open the cleanup page and mark orphaned data as reviewed. |
| src/System Application/App/Extension Management/src/ExtensionManagement.Page.al | Detects unreviewed orphaned data on page open and sends a notification with actions. |
| src/System Application/App/Extension Management/src/DeleteOrphanedExtensionData.Page.al | Adds “Reviewed” field and an action to bulk-mark orphaned extension data as reviewed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…y-About-Uninstalled-Extensions
…y-About-Uninstalled-Extensions
Summary
When opening the Extension Management page, a notification is now displayed if there are extensions that have been uninstalled but still have synchronized data. The notification includes a "Show Extensions" action that opens the "Delete Orphaned Extension Data" page, allowing users to review and clean up leftover data from uninstalled extensions.
Work Item(s)
Fixes AB#616423