28.x - Migrate File Storage Connector#7851
Open
aholstrup1 wants to merge 2 commits intoreleases/28.xfrom
Open
Conversation
…ests Removes the app and its associated test app from the repository. App ID: 79447b11-8301-4d02-a546-2261eb811296 Test App ID: 80ef626f-e8de-4050-b144-0e3d4993a718
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the External File Storage – Azure File Service Connector app (and its associated test app) from the W1 apps set, consistent with a “migrate/remove” action so the connector is no longer shipped from this repo/branch.
Changes:
- Removed the Azure File Share connector implementation (account table/pages, auth enum, enum extension registration, permissions, entitlement, and connector logic).
- Removed the connector’s dedicated test app (tests, mock codeunit, and test app manifest).
- Removed connector app metadata/resources (app.json/README and related assets).
Reviewed changes
Copilot reviewed 17 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Apps/W1/External File Storage - Azure File Service Connector/Test/src/mocks/ExtFileAccountMock.Codeunit.al | Removed mock account helper used by connector tests. |
| src/Apps/W1/External File Storage - Azure File Service Connector/Test/src/ExtAzureFileServiceTest.Codeunit.al | Removed test codeunit covering account registration, environment cleanup disabling, and show-account UI. |
| src/Apps/W1/External File Storage - Azure File Service Connector/Test/app.json | Removed the test app package manifest and dependencies. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareConnectorImpl.Codeunit.al | Removed the connector implementation for file/directory operations and account registration. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareConnector.EnumExt.al | Removed the enum extension that registers the “File Share” connector implementation. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAuthType.Enum.al | Removed the connector-specific authorization type enum. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAccountWizard.Page.al | Removed the account registration wizard page. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAccount.Table.al | Removed the persisted account table (incl. isolated storage secret handling). |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/src/ExtFileShareAccount.Page.al | Removed the account card page. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/permissions/*.al | Removed connector permission sets and permission set extensions. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/app.json | Removed the connector app manifest (id, versioning, idRanges, resources). |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/README.md | Removed the connector app README. |
| src/Apps/W1/External File Storage - Azure File Service Connector/App/Entitlements/ExtFileShareConnector.Entitlement.al | Removed the implicit entitlement definition for the connector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#632422