Enable cache_only mode for the BF-Tree cache#810
Merged
hildebrandmw merged 3 commits intomainfrom Mar 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables BF-Tree’s cache_only mode so the caching layer behaves as a true fixed-capacity cache (rather than falling back to an in-memory backing store that undermines eviction).
Changes:
- Switch BF-Tree config to
cache_only(true)in the cache constructor. - Update the cache metrics test expectations for initial utilization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
diskann-providers/src/model/graph/provider/async_/caching/bf_cache.rs
Outdated
Show resolved
Hide resolved
…ache.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
metajack
approved these changes
Mar 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 432 432
Lines 79452 79452
=======================================
Hits 71075 71075
Misses 8377 8377
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
harsha-simhadri
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was left as a TODO pending a backend fix to
bf-tree. That change has since been made, but this was never updated. Withoutcache_only, a memory-fs will be used which prevents BF-Tree from actually working as a fixed-capacity cache.