Skip to content

Enable cache_only mode for the BF-Tree cache#810

Merged
hildebrandmw merged 3 commits intomainfrom
mhildebr/cache
Mar 3, 2026
Merged

Enable cache_only mode for the BF-Tree cache#810
hildebrandmw merged 3 commits intomainfrom
mhildebr/cache

Conversation

@hildebrandmw
Copy link
Contributor

This was left as a TODO pending a backend fix to bf-tree. That change has since been made, but this was never updated. Without cache_only, a memory-fs will be used which prevents BF-Tree from actually working as a fixed-capacity cache.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables BF-Tree’s cache_only mode so the caching layer behaves as a true fixed-capacity cache (rather than falling back to an in-memory backing store that undermines eviction).

Changes:

  • Switch BF-Tree config to cache_only(true) in the cache constructor.
  • Update the cache metrics test expectations for initial utilization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ache.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.45%. Comparing base (f206264) to head (038ad2b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files         432      432           
  Lines       79452    79452           
=======================================
  Hits        71075    71075           
  Misses       8377     8377           
Flag Coverage Δ
miri 89.45% <ø> (ø)
unittests 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hildebrandmw hildebrandmw merged commit 955fdce into main Mar 3, 2026
24 checks passed
@hildebrandmw hildebrandmw deleted the mhildebr/cache branch March 3, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants