feat: add presence runtime validator functions#1664
Open
tylerbutler wants to merge 2 commits intocanvasfrom
Open
feat: add presence runtime validator functions#1664tylerbutler wants to merge 2 commits intocanvasfrom
tylerbutler wants to merge 2 commits intocanvasfrom
Conversation
tylerbutler
commented
Oct 13, 2025
Comment on lines
+18
to
+19
| // Re-export type for external consumers | ||
| export type { CursorState }; |
Member
Author
There was a problem hiding this comment.
This pattern reduces the amount of churn, but if we prefer direct imports I can make that change.
tylerbutler
commented
Oct 13, 2025
| */ | ||
| export interface DragManager<TDragPackage extends DragPackage | null = DragPackage | null> | ||
| extends PresenceManager<TDragPackage> { | ||
| export interface DragManager<TDragPackage> extends PresenceManager<TDragPackage> { |
Member
Author
There was a problem hiding this comment.
This null removal is likely wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds presence runtime validation for the canvas example. The validation itself is handled by zod.