Build SQLServerSpatialTools with dotnet core on macos#15
Open
tbbuck wants to merge 3 commits intomicrosoft:masterfrom
Open
Build SQLServerSpatialTools with dotnet core on macos#15tbbuck wants to merge 3 commits intomicrosoft:masterfrom
tbbuck wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Sets target framework to net481, referencing Microsoft.NETFramework.ReferenceAssemblies and setting <Project Sdk="Microsoft.NET.Sdk" to enable the build magic. Removes pfx certificate building because not supported, LRS code because breaks build, and uses Microsoft.SqlServer.Server and Microsoft.SqlServer.Types from Nuget rather than local filesystem. Also disables AssemblyInfo.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
This pull requests aligns the
csprojwith dotnet core 9 so that modern users can build and deploy SQLServerSpatialTools without having to resort to finding legacy Visual Studio installs on Windows with out-of-support .net framework versions.I have also modified the project file to use Microsoft.SqlServer.Server and "Microsoft.SqlServer.Types from Nuget, which means users don't have to download any extra files or rely on local filesystem setup in order to build SqlServerSpatial Tools.
While I can't see any reason that this wouldn't build on other platforms, this has not been tested. I'm happy to make corrections should something be discovered all the same.
Apologies for the terse pull request - I found myself in a hole, am digging my way out, and hope that this can help other people suffering from similar!
The .dll is currently running on my test SQL Server 2022 server, and is giving every indication of working well.
Thanks,
Tom.