Conversation
bghgary
approved these changes
Feb 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase from C++17 to C++20 standard, removing legacy Visual Studio and Android project files in favor of CMake-only builds, and eliminating an Android NDK workaround for string_view that is no longer needed.
Changes:
- Updated CMAKE_CXX_STANDARD from 17 to 20 in CMakeLists.txt
- Updated README documentation to reflect C++20 compiler requirements
- Removed obsolete Visual Studio (.vcxproj) and shared items (.vcxitems) files for Windows and Android platforms
- Removed Android NDK experimental string_view workaround since C++17+ provides standard string_view
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Updated C++ standard from 17 to 20 |
| README.md | Updated minimum compiler version requirements for C++20 |
| Source/Shared/arcana/string.h | Removed Android NDK workaround for experimental::string_view |
| Source/Windows/Arcana.Windows.vcxproj | Deleted legacy Visual Studio project file (C++17 build configuration) |
| Source/Windows/Arcana.Windows.Reference.vcxitems | Deleted legacy shared items file |
| Source/Shared/Arcana.vcxitems | Deleted legacy shared items file |
| Source/Android/Arcana.Android.vcxproj | Deleted legacy Android project file (C++17 build configuration) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
auto-merge was automatically disabled
February 12, 2026 20:12
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to C++ 20.