Suppress compiler warning on potential buffer overflow#935
Open
doctorlai-msrc wants to merge 3 commits intomicrosoft:devfrom
Open
Suppress compiler warning on potential buffer overflow#935doctorlai-msrc wants to merge 3 commits intomicrosoft:devfrom
doctorlai-msrc wants to merge 3 commits intomicrosoft:devfrom
Conversation
daanx
added a commit
that referenced
this pull request
Dec 30, 2024
Collaborator
|
I think the warning is due to reading the atomic directly -- I added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler gives the warning at (this issue):
It is detecting a potential buffer overflow when accessing the thread_id in the segment structure. The warning suggests that the compiler believes the thread_id is being accessed in a way that could lead to reading or writing beyond the allocated memory of the structure.
This PR suppress this warning as I believe the code is safe (the false positive)