Strip .il and .ni suffixes from TraceModuleFile.Name#2364
Open
leculver wants to merge 1 commit intomicrosoft:mainfrom
Open
Strip .il and .ni suffixes from TraceModuleFile.Name#2364leculver wants to merge 1 commit intomicrosoft:mainfrom
leculver wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Fix dotnet/diagnostics#3102: EventPipe module names have unexpected .il suffix. TraceLog.ManagedModuleLoadOrUnload creates synthetic .il.dll paths for ReadyToRun assemblies to maintain separate IL and native PDB entries. This is an internal implementation detail that was leaking into the user-visible Name property, causing tools like dotnet-stack, PerfView, and WPA to display module names like 'System.Private.CoreLib.il' instead of 'System.Private.CoreLib'. Strip the .il and .ni suffixes in TraceModuleFile.Name, matching the same logic already used in GetSourceLine() for source resolution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
leculver
requested review from
StephenMolloy,
brianrob,
cincuranet,
marklio and
mconnew
as code owners
Collaborator
Author
|
TraceEvent tests pass (well, they match the baseline of main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dotnet/diagnostics#3102: EventPipe module names have unexpected .il suffix.
TraceLog.ManagedModuleLoadOrUnload creates synthetic .il.dll paths for ReadyToRun assemblies to maintain separate IL and native PDB entries. This is an internal implementation detail that was leaking into the user-visible Name property, causing tools like dotnet-stack, PerfView, and WPA to display module names like 'System.Private.CoreLib.il' instead of 'System.Private.CoreLib'.
Strip the .il and .ni suffixes in TraceModuleFile.Name, matching the same logic already used in GetSourceLine() for source resolution.