RemoveDirectoryOptions::RemoveReadOnly should remove both read-only files and directories

[dimhotepus]

Closes #565

[dunhor]

Presumably GetLastError won't contain failure because you just called GetFileAttributesW right before this (which probably succeeded). And even if it did fail, you probably want the original error from the call to RemoveDirectoryW

[dunhor]

Is this necessary? Presumably the attributes have FILE_ATTRIBUTE_DIRECTORY set at a minimum.

[dunhor]

@ChrisGuzak and @jonwis for their thoughts.

This jumps out as potentially concerning because it's changing behavior of something that an existing application could theoretically be depending on. The safest route would be to introduce a new flag - RemoveDirectoryOptions::RemoveReadOnlyDirectory - and possibly add a new RemoveDirectoryOptions::RemoveReadOnlyFile that aliases RemoveDirectoryOptions::RemoveReadOnly.

That said, looking around at existing uses of RemoveDirectoryOptions::RemoveReadOnly, there doesn't appear to be that many instances outside of test code, so this might just be okay.

[dunhor]

The impact is presumably limited to just the directories themselves, so all of the directory contents would still get deleted, so the impact from, say, a security perspective, seems low.

[jonwis]

Yeah, I like that additional flag for "... and your little readonly dirs, too!" mode. Thanks for the change.