enhance: アバターデコレーションへのカテゴリの導入#17034
Open
EbiseLutica wants to merge 8 commits intomisskey-dev:developfrom
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #17034 +/- ##
===========================================
+ Coverage 63.53% 63.56% +0.03%
===========================================
Files 1163 1163
Lines 116166 116190 +24
Branches 8388 8405 +17
===========================================
+ Hits 73803 73854 +51
+ Misses 40154 40127 -27
Partials 2209 2209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Backend memory usage comparisonBefore GC
After GC
After Request
|
Contributor
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -3318,6 +3318,12 @@
"items": {
"type": "string"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -3367,6 +3373,12 @@
"type": "string",
"format": "id"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -3376,7 +3388,8 @@
"name",
"description",
"url",
- "roleIdsThatCanBeUsedThisDecoration"
+ "roleIdsThatCanBeUsedThisDecoration",
+ "category"
]
}
}
@@ -3735,6 +3748,12 @@
"type": "string",
"format": "id"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -3903,6 +3922,12 @@
"items": {
"type": "string"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -51264,6 +51289,12 @@
"type": "string",
"format": "id"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [ |
7b5389a to
844bf91
Compare
Member
|
(追加されたUIのキャプチャがあるとレビューがスムーズかもしれません) |
Contributor
Author
|
画面キャプチャを追加しておきました |
Contributor
kakkokari-gtyih
left a comment
There was a problem hiding this comment.
group-avatar-decorations.ts が用意されているにも関わらず使われていないかもしれません
samunohito
reviewed
Dec 25, 2025
Member
samunohito
left a comment
There was a problem hiding this comment.
バックエンド側実装は問題ないと思います(フロントエンド側は任せた)。
ただ、1点だけ軽微な指摘があります。
packages/backend/migration/1766652173085-add-category-to-avatar-decorations.js
Show resolved
Hide resolved
a75c87c to
552dff7
Compare
Contributor
Author
|
@samunohito @kakkokari-gtyih 遅くなってすみません。ご指摘いただいた箇所の修正をいたしました また、最新版をマージしたことで型エラーが生じたので、 7014326 でgroupAvatarDecorations関数をジェネリック化することで対処しています |
samunohito
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
close #16854
アバターデコレーションに、カスタム絵文字と同様にカテゴリを設定できるようにしました。
Why
1画面に収まりきらないほど多くのデコレーションを登録しているサーバーにおいて整理できるようにし、管理画面およびアバターデコレーション設定画面の見通しの改善を支援します
Additional info (optional)
管理画面のスクリーンショット
一覧画面

編集画面

プロフィール画面のスクリーンショット
Checklist