[F-20] fix(bup,sync): add return-value checks on external script system() calls#140
Merged
adequatelimited merged 1 commit intoaudit-fixesfrom Apr 6, 2026
Merged
Conversation
Closes #109 system() calls to ../update-external.sh and ../init-external.sh had no return-value checks. A failed or erroring script was silently ignored. Added checks and pwarn() logging on non-zero return so failures are visible in the node log.
Collaborator
Author
|
Last two system() calls in the codebase, we'll at least check the return codes to make sure they did what we wanted, or log a warning if they didn't. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109
Summary
The two external script hooks —
../update-external.sh(called on every block update) and../init-external.sh(called after resync) — had no return-value checks on theirsystem()calls. A failed script was silently ignored.Change
Added
system() != 0check withpwarn()logging at both sites. The scripts remain invoked viasystem()since their purpose is to run external programs.The relative path and
fexists()pre-check are unchanged — the audit noted these as concerns, but they are by-design (the scripts are optional hooks located relative to the node's working directory).Testing
-Wall -Werror -Wextra -Wpedantic