fix(network): close socket on every exit path in get_hash() (F-31, #117)#159
Merged
adequatelimited merged 1 commit intoaudit-fixesfrom Apr 13, 2026
Merged
Conversation
get_hash() leaked np->sd on send_op() or recv_tx() failure: both early returns skipped sock_close(). Under repeated peer probing failures (common on unreachable or misbehaving peers) this exhausts the fd limit and prevents new outbound connections. Restructure with a single CLEANUP label so every exit path -- success, I/O failure, and malformed response -- closes the socket before returning. Matches the DROP_CLEANUP/ERROR_CLEANUP idiom used elsewhere in the codebase.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #117 (F-31).
`get_hash()` leaked `np->sd` on `send_op()` or `recv_tx()` failure — both early returns skipped `sock_close()`. Under repeated peer probing failures (common with unreachable or misbehaving peers) this exhausts the process fd limit and prevents new outbound connections.
Restructured with a single `CLEANUP` label so every exit path (success, I/O failure, malformed response) closes the socket before returning. Matches the `DROP_CLEANUP` / `ERROR_CLEANUP` idiom used elsewhere in the codebase.
Test plan