Make THESEUS_CONFIG_DIR work in dev mode#5355
Open
creeperkatze wants to merge 4 commits intomodrinth:mainfrom
Open
Make THESEUS_CONFIG_DIR work in dev mode#5355creeperkatze wants to merge 4 commits intomodrinth:mainfrom
creeperkatze wants to merge 4 commits intomodrinth:mainfrom
Conversation
Contributor
Author
|
Just a little disclaimer, this changes the behavior to use compile-time environment variables (requiring rebuild to change). While the env variable shouldnt interfere with any app migration stuff, this could be breaking if THESEUS_CONFIG_DIR i used in some non-dev context. |
IMB11
added
the
📂 Under review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes THESEUS_CONFIG_DIR not working when running the app via
app:devby usingoption_env!()(compile-time) instead ofstd::env::var_os()(runtime).This aligns with the existing pattern used by MODRINTH_URL and other environment variables.