fix(setup): improve PHP version error message in bootstrap#16922
Open
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Open
fix(setup): improve PHP version error message in bootstrap#16922Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Conversation
- Title: 'PHP version is not supported' - Description: 'Your PHP version (%s) is no longer supported. Please upgrade to PHP %s or higher to install MODX.' Split from modxcms#16921 per review; relates to modxcms#14990.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates the PHP version requirement error in the setup bootstrap: the title is changed to "PHP version is not supported" and the description to "Your PHP version (%s) is no longer supported. Please upgrade to PHP %s or higher to install MODX."
Why is it needed?
Clearer, more neutral wording when the user's PHP version is below the minimum. Avoids a harsh "Wrong PHP Version!" message and gives a direct upgrade instruction. Addresses the UX concern from issue #14990 (showing a warning instead of a fatal error when possible).
How to test
Related issue(s)/PR(s)
Resolves #14990 (message part).
Split from #16921 per review (separate concern from PHP extension requirements).