Add internationalization for third-party styles#137
Merged
monperrus merged 1 commit intomonperrus:masterfrom Sep 8, 2025
Merged
Add internationalization for third-party styles#137monperrus merged 1 commit intomonperrus:masterfrom
monperrus merged 1 commit intomonperrus:masterfrom
Conversation
Added proper internationalization for JanosBibliographyStyle and VancouverBibliographyStyle. Translation of strings like "in", "Master's Thesis" etc. was missing.
Owner
|
Thanks a lot @frederikmoellers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The styles
JanosBibliographyStyleandVancouverBibliographyStylemake use of some existing functions (e.g. to create the list of authors) which in turn use internationalization (__()). However, several language-specific strings are hard-coded in these styles.When using translations, these two styles result in garbeled language. The list of authors will have proper translation (e.g. a German "und" instead of the english "and" between the last two authors), but then things like "Master's Thesis", "vol." (for the journal volume) and "pp." (for the page numbers) is not translated.
This PR adds the missing calls to the internationalization functions for all relevant strings.