Add internationalization for third-party styles#139
Closed
frederikmoellers wants to merge 2 commits intomonperrus:masterfrom
Closed
Add internationalization for third-party styles#139frederikmoellers wants to merge 2 commits intomonperrus:masterfrom
frederikmoellers wants to merge 2 commits intomonperrus:masterfrom
Conversation
Added proper internationalization for JanosBibliographyStyle and VancouverBibliographyStyle. Translation of strings like "in", "Master's Thesis" etc. was missing.
Owner
|
Thanks @frederikmoellers . However, the diff is empty. Could you fix it? |
Contributor
Author
|
The first commit of the PR should not be empty. The second is only a merge commit because I didn't rebase my changes. If you want the PR without the merge commit, I can do that. |
Owner
|
yes, so there has been something wrong on the merge. we need to fix this for sake of transparency. Thanks! |
Owner
|
merged manually, see a8c24da thanks for the contribution |
Contributor
Author
|
Thank you very much! And sorry for not providing a proper PR in time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some parts of the third-party styles, notably
JanosBibliographyStyleandVancouverBibliographyStyleare missing proper internationalization. This PR adds the corresponding calls for strings like "in", "Master's Thesis" etc.