fix: improve mobile review card scrolling and swipe gestures#167
Open
jonathanKingston wants to merge 1 commit intomozilla-ai:mainfrom
Open
fix: improve mobile review card scrolling and swipe gestures#167jonathanKingston wants to merge 1 commit intomozilla-ai:mainfrom
jonathanKingston wants to merge 1 commit intomozilla-ai:mainfrom
Conversation
peteski22
force-pushed
the
jkt/mobile-review-scroll-swipe
branch
from
85d13c8 to
8a5131b
Compare
Keep the review page locked to the viewport, move long-form content scrolling into the card body, and make mobile swipe gestures hold onto horizontal intent even when a thumb path drifts vertically. Made-with: Cursor
peteski22
force-pushed
the
jkt/mobile-review-scroll-swipe
branch
from
8a5131b to
ee4e06f
Compare
Collaborator
|
@jonathanKingston thanks for the PR, I tried it out locally but it seems to make the desktop browser behave strangely once you've clicked and are dragging, it locks to that option no matter where you drag it. I think it might need a bit more attention if you've got any time? 
|
peteski22
added
waiting-for-response
Contributor
Author
|
I did take a look but couldn’t get it to work show I think it should work. I’ll take another look when travelling to see if it’s a simple fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the review page locked to the viewport, move long-form content scrolling into the card body, and make mobile swipe gestures hold onto horizontal intent even when a thumb path drifts vertically.