Session refactor and execution provider management#390
Merged
javiermtorres merged 15 commits intomainfrom Apr 18, 2026
Merged
Conversation
added 15 commits
April 14, 2026 19:10
javiermtorres
commented
Apr 17, 2026
| impl ModelTypeExt for crate::common::ModelType { | ||
| fn validate_model<'a>(&self, path: &'a Path) -> Result<PlannedAsset<'a>> { | ||
| let model = load_model(path)?; | ||
| let model = ORTSessionBuilder::default().from_file(path)?; |
Contributor
Author
There was a problem hiding this comment.
Since this is done just once, we can do away with early building a session, right?
| } | ||
|
|
||
| fn get_tensorrt_provider(device_id: i32) -> Result<ExecutionProviderDispatch> { | ||
| if !CUDA_ENABLED { |
Contributor
Author
There was a problem hiding this comment.
Is CUDA available whenever TensorRT is? Otherwise we might need specific flags.
| #[arg(long, default_value_t = false)] | ||
| disable_cpu_fallback: bool, | ||
| #[arg(long)] | ||
| graph_optimization_level: Option<GraphOptimizationLevel>, |
Contributor
Author
There was a problem hiding this comment.
I suppose clap gives an appropriate error if we step out of the possible values, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.