Skip to content

Remove unnecessary if statements #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fuerback wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary if statements #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions cachetable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func (table *CacheTable) SetAddedItemCallback(f func(*CacheItem)) {
table.addedItem = append(table.addedItem, f)
}

//AddAddedItemCallback appends a new callback to the addedItem queue
// AddAddedItemCallback appends a new callback to the addedItem queue
func (table *CacheTable) AddAddedItemCallback(f func(*CacheItem)) {
table.Lock()
defer table.Unlock()
Expand Down Expand Up @@ -181,10 +181,8 @@ func (table *CacheTable) addInternal(item *CacheItem) {
table.Unlock()

// Trigger callback after adding an item to cache.
if addedItem != nil {
for _, callback := range addedItem {
callback(item)
}
for _, callback := range addedItem {
callback(item)
}

// If we haven't set up any expiration check timer or found a more imminent item.
Expand Down Expand Up @@ -219,10 +217,8 @@ func (table *CacheTable) deleteInternal(key interface{}) (*CacheItem, error) {
table.Unlock()

// Trigger callbacks before deleting an item from cache.
if aboutToDeleteItem != nil {
for _, callback := range aboutToDeleteItem {
callback(r)
}
for _, callback := range aboutToDeleteItem {
callback(r)
}

r.RLock()
Expand Down