Fixing couple of open issues (logic bugs) and a security issue#509
Open
VissaMoutafis wants to merge 2 commits intonasa:devfrom
Open
Fixing couple of open issues (logic bugs) and a security issue#509VissaMoutafis wants to merge 2 commits intonasa:devfrom
VissaMoutafis wants to merge 2 commits intonasa:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes
Fixing issues
sdls_frame.hdr.pkt_lengthis not updated properly inCrypto_Process_Extended_Procedure_Pdu#505iv_len) #508How do you test these changes?
Followed the replication section from each issue and check the validity using a debugger and logs.
Disclaimer
All the bugs fixed by this pull request were discovered through a TU Delft funded project during my time as a PhD researcher and a visiting researcher at the European Space Agency.