833 improve adac

[msuder]

Summary of PR goals.

How to test?

• Run NOS3 via make launch
• Click OK on the COSMOS splash screen
• Click COSMOS to start the COSMOS command and telemetry server, the command sender and the packet viewer.
• Click Test Runner
• Select the Test Suite Generic_adcs_Test in the Test Runner and click Start to run this test suite
• Verify that the test suite finishes successfully
• For Fprime: Build & Launch Fprime Config, Set ADCS mode to SUNSAFE, make sure B1 & Sun Vector Match.

Submodule PRs and actions prior to closing this:

• 833 improve adac nasa-itc/generic_adcs#19
• 833 improve adac nasa-itc/novatel_oem615#19
• 833 improve adac nasa-itc/fprime-nos3#31

Closes #833 .

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.06%. Comparing base (842aa0e) to head (ba6c8db).
⚠️ Report is 23 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #835      +/-   ##
==========================================
- Coverage   72.74%   72.06%   -0.69%     
==========================================
  Files         761      761              
  Lines       90262    91123     +861     
  Branches     7133     7293     +160     
==========================================
+ Hits        65664    65668       +4     
- Misses      24598    25455     +857     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Isgaroth-the-Green]

Everything worked as intended; the tests were much more reliable than before.

[zlynch2]

Passes cFS and cosmos side. still need to test Fprime since changed some shared files. So far so good.

[zlynch2]

Fprime doesnt build - due to adcs changes , need to address fprime compilation errors.

[KushalP17]

Fprime ADCS working again, added new GPS ports in Fprime to match cFS additions. Keep in mind, there are some broken things on the Fprime side (SPI Components) that are a separate issue, so this will not fix those. Even without Fprime working perfectly, ADCS works well.

[zlynch2]

approving, fprime edits seem to work, added spi interface fix by adding sleep to allow time to initialize. Still debugging #828 separately