Skip to content

fix: test embedding float32 followup (GENKGB-1065)#514

Merged
matteomedioli merged 1 commit intomainfrom
matteo/fix-test-embedding-float-32-GENKGB-1065
Apr 17, 2026
Merged

fix: test embedding float32 followup (GENKGB-1065)#514
matteomedioli merged 1 commit intomainfrom
matteo/fix-test-embedding-float-32-GENKGB-1065

Conversation

@matteomedioli
Copy link
Copy Markdown
Contributor

Post-review fixes for Neo4jGraphParquetFormatter - Follow-up to #500

This PR contains the post-review improvements suggested on #500.

Changes:

  • Cast integer embedding vectors (e.g. all-zero or one-hot) to float32, not just float ones
  • Document the list limitation for empty-list-only columns (known issue with DuckDB/Spark)
  • Fix test assertion to match the updated behaviour

@matteomedioli matteomedioli changed the title Matteo/fix test embedding float 32 genkgb 1065 fix: test embedding float32 followup (GENKGB-1065) Apr 17, 2026
@matteomedioli matteomedioli marked this pull request as ready for review April 17, 2026 14:54
@matteomedioli matteomedioli requested a review from a team as a code owner April 17, 2026 14:54
Copy link
Copy Markdown
Contributor

@ali-sedaghatbaf ali-sedaghatbaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matteomedioli matteomedioli merged commit 4d4a6d9 into main Apr 17, 2026
14 of 16 checks passed
@matteomedioli matteomedioli deleted the matteo/fix-test-embedding-float-32-GENKGB-1065 branch April 17, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants