Conversation
|
And I'll start by fixing some conflicts 👍 |
55b0b2a to
5cf0a27
Compare
Signed-off-by: sim <git@sgougeon.fr>
The capability doesn't have an accountName, and therefore doesn't update the user cache Signed-off-by: sim <git@sgougeon.fr>
…e message Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
…ilable Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
To catch easily when we do UnifiedPush or Common push tasks Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
… a distributor Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
…nregistration Signed-off-by: sim <git@sgougeon.fr>
Signed-off-by: sim <git@sgougeon.fr>
5cf0a27 to
84bf56d
Compare
| private fun appTypes(): List<String> = context.packageManager | ||
| .getLaunchIntentForPackage(APP_NEXTCLOUD_TALK)?.let { | ||
| listOf("all", "-talk") | ||
| } ?: listOf("all") |
There was a problem hiding this comment.
That is to get all notifications, except talk ones if talk is installed. But:
- We can decide to never receive talk notifications (if a user wants talk notif, they probably use Talk app)
- And it would be better to list the applications we want to receive notifications from
There was a problem hiding this comment.
What about talk notifications? Is it expected that the talk app will independently handle unifiedpush notifications too?
There was a problem hiding this comment.
I'm cleaning up the code to open the pull request
| @JvmStatic | ||
| fun registerCurrentPushConfiguration(activity: Activity, accountManager: UserAccountManager, preferences: AppPreferences) { | ||
| if ( | ||
| (!preferences.isPushInitialized && BuildConfig.DEFAULT_PUSH_UNIFIEDPUSH) |
There was a problem hiding this comment.
Instead of using a BuildConfig, we could add a function isPlayServiceAvailable to PushUtils (Implemented per flavor, dedicated to FCM and proxy-push) to check if the Play Services are available.
That way, a user using the gplay flavor on a phone without the Play Services can use by default UnifiedPush.
But it introduces a bit more change, and it is a bit less readable. As you want
Following web push support in nextcloud/notifications, we can add UnifiedPush support to the Android application*, to get push notifications even without the Play Services.
The implementation follows this guide: https://unifiedpush.org/developers/ux/
This feature also gives the possibility to get Push Notifications with the Play Services, without the proxy (Nextcloud servers directly push to Google FCM servers), and without a proprietary library. So this is an accepted way to use FCM for application in F-Droid. => This is in a 2nd PR, already ready.
Fix #11898
Fix #5510
Fix #8684
Fix #3333 (with the 2nd PR)
* We could add it to the Linux app too, but I haven't, at least yet.
🖼️ Screenshots
Coming, I will update this description
🏁 Checklist