Allow usage of Microsoft graph to lookup guid to group names on EntraID#1379
Allow usage of Microsoft graph to lookup guid to group names on EntraID#1379small1 wants to merge 6 commits intonextcloud:mainfrom
Conversation
julien-nc
left a comment
There was a problem hiding this comment.
Thank you for the PR!
- I feel like this change is too specific to one provider to justify adding an option in the UI. It would be fine if the flag can only be set via the occ command. Wdyt?
- Can you rename the new option in the upsert command from
entraidto something more explicit likeazure-group-names? - Can you isolate the 2 change blocks in
ProvisioningService.phpin new methods to avoid making thegetSyncGroupsOfTokenone too long and more difficult to read?
In this case it is EntraID so entraid-group-names yes sure (This was developed when the name was Azure AD). And we can remove the ui option. I actually just added the occ command when i submitted this. The last one i can check. A bit above my development skills Ill make an effort and ask for some assistance on that one. |
|
Sure feel free to ask for assistance. Are you asking me? About my last change request, it would be replacing each of the 2 blocks you inserted in I can make this change (after you've made the other adjustments) if you ask me to. |
I have made changes and tested them. I would appretiate assistance with the method part from you @julien-nc :) |
697d099 to
d545d8e
Compare
…ra ID Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
…, update readme Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
This patch will allow to lookup group guid on Microsoft Graph and store that as group name in Nextcloud.
It will only lookup groups if "Fetch group names from Microsoft Graph" is checked. Otherwise it will run as normal.
Code has been tested and works against EntraID
Fixes #640 and #1017