Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
- Coverage 85.12% 84.93% -0.19%
==========================================
Files 105 104 -1
Lines 13705 13581 -124
==========================================
- Hits 11666 11535 -131
- Misses 1524 1531 +7
Partials 515 515
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dhurley
reviewed
Jan 20, 2026
dhurley
approved these changes
Feb 12, 2026
Akshay2191
approved these changes
Feb 19, 2026
craigell
approved these changes
Feb 20, 2026
dhurley
reviewed
Apr 28, 2026
Collaborator
dhurley
left a comment
There was a problem hiding this comment.
Can we double check the other functions in the nginx-app-protect-instance-watcher.go to make sure we have correct locks in place for the nginxAppProtectInstance field?
dhurley
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR removes each instance having its own Instance operator and health watcher.
It also moves the logic for updating the resource into the instance watcher to reduce the amount of messages being sent on the bus.
The resource plugin has been remnemed to the nginx plugin as it now only has logic to apply, relaod and validate the nginx config.
NAP no longer has its own instance watcher, the nap instance watcher is now started in the instance watcher and is checked for updates when we check for instance updates reducing complexity and the number of messages being sent.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)