NGF: Update proxy settings policy for timeouts#1877
Merged
ciarams87 merged 3 commits intongf-release-2.6from Apr 28, 2026
Merged
NGF: Update proxy settings policy for timeouts#1877ciarams87 merged 3 commits intongf-release-2.6from
ciarams87 merged 3 commits intongf-release-2.6from
Conversation
github-actions
Bot
added
documentation
✅ Deploy Preview will be available once build job completes!
|
sjberman
reviewed
Apr 22, 2026
sjberman
reviewed
Apr 22, 2026
| - `read`: time allowed between two successive **read operations** from the upstream server — not the total time to receive the full response. If the upstream does not transmit anything within this period, the connection is closed. | ||
| - `send`: time allowed between two successive **write operations** to the upstream server — not the total time to transmit the full request. | ||
|
|
||
| Because `read` and `send` are per-operation rather than end-to-end timeouts, a large response or request body can take longer than the configured value as long as data keeps flowing within the timeout window. NGINX does not currently support full request or response timeouts. |
Contributor
There was a problem hiding this comment.
I'm wondering if we include the part about NGINX not supporting full timeouts. While useful information, when we do support them, we'll probably forget to remove this.
sjberman
approved these changes
Apr 27, 2026
bjee19
approved these changes
Apr 27, 2026
JTorreG
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the documentation for ProxySettingsPolicy to add timeout configuration
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩