sqlite: refactor error helpers and user function pointers#62794
Open
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Open
sqlite: refactor error helpers and user function pointers#62794thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62794 +/- ##
==========================================
- Coverage 89.69% 89.68% -0.02%
==========================================
Files 706 706
Lines 218247 218252 +5
Branches 41777 41782 +5
==========================================
- Hits 195760 195730 -30
- Misses 14401 14438 +37
+ Partials 8086 8084 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small independent refactors.
CreateSQLiteErroroverloadsBaseObjectWeakPtrfor user functions (style consistency)