Skip to content

test: normalize known inspector crash as completion#62851

Open
joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung:probe-error
Open

test: normalize known inspector crash as completion#62851
joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung:probe-error

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

This works around a pre-existing inspector issue: if the debuggee exits too quickly the inspector can segfault while tearing down. For now normalize the trailing segfault as completion to keep the CI green until the upstream bug is fixed, since it only reproduces on some slow CI machines and is not what the probe tests care about.

Refs: #62765
Refs: #58245

This works around a pre-existing inspector issue:
if the debuggee exits too quickly the inspector can
segfault while tearing down. For now normalize the
trailing segfault as completion to keep the CI green
until the upstream bug is fixed, since it only
reproduces on some slow CI machines and is not
what the probe tests care about.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (14e16db) to head (678ee5b).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62851   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         706      706           
  Lines      219136   219136           
  Branches    41987    41982    -5     
=======================================
+ Hits       196404   196405    +1     
+ Misses      14611    14606    -5     
- Partials     8121     8125    +4     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung added the review wanted PRs that need reviews. label Apr 20, 2026
@joyeecheung
Copy link
Copy Markdown
Member Author

cc @legendecas @hybrist

@hybrist
Copy link
Copy Markdown
Contributor

hybrist commented Apr 20, 2026

I was about to suggest something about .at(-1) / pop/push but I'm not sure it actually makes this test-only logic much easier to read. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants