Add warning for data source gotcha in NetTopologySuite docs#328
Open
douglasg14b wants to merge 1 commit intonpgsql:mainfrom
Open
Add warning for data source gotcha in NetTopologySuite docs#328douglasg14b wants to merge 1 commit intonpgsql:mainfrom
douglasg14b wants to merge 1 commit intonpgsql:mainfrom
Conversation
Member
|
@douglasg14b the general idea seems to be covered in the basic usage docs:
However, it's true that lots of people have run into this problem. I think a better way here is to add a sample in the basic usage page specifically for DI with AddDbContext, plus a warning there. Then, from the various plugin pages, we can link to the part of the basic usage page. What do you think? |
Author
|
@roji The quote covers this only after one is knowledgeable about the problem IMHO. This is an unexpected side effect that violates that "rule", but not in a way that is obvious or intentional. Which is why the suggested warning to avoid the pitfall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got hung up on this one for quite a while, it's an easy gotcha to run into if you are setting up
NetTopologySuitein an existing application that obtains the connection string via DI inside of the configuring callback ofAddDbContext.Setting up the data source inside of the
OnConfiguringcallback causes the dependencies of theDbContextOptionsto be different every time, causing a newServiceProviderto be made for eachDbContextwhich will eventually warn/error with theLogManyServiceProvidersCreatederror in EF Core.Please advise preferred verbiage and location.