Skip to content

container: Support initial placement policy#381

Merged
cthulhu-rider merged 1 commit intomasterfrom
initial-placement
Feb 26, 2026
Merged

container: Support initial placement policy#381
cthulhu-rider merged 1 commit intomasterfrom
initial-placement

Conversation

@cthulhu-rider
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread container/types.proto Outdated
@cthulhu-rider cthulhu-rider force-pushed the initial-placement branch 2 times, most recently from e735800 to a0eac9f Compare February 25, 2026 05:58
Closes #352.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Comment thread netmap/types.proto
//
// `replica_limits` allows to override `Replica.count` and EC partitions. If
// set, `replica_limits` must have a length equal to the sum of `replicas`
// (`RN`) and `ec_rules` length. Each of first `RN` elements of
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does RN mean?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias to use briefly further

Comment thread netmap/types.proto
// replica limit (`replica_limits` or main ones).
//
// `prefer_local` allows to tell server to try to store `MaxReplicas`
// replicas in locations that include this server. `prefer_local` must be set
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this line mean it is impossible to use prefer_local with non-empty replica_limits? the issue provides an example that allows it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, there is no such restriction in this statement

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, that is how i understood it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this paragraph does not contain replica_limits at all. So i did not catch ur thought

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i read it as prefer_local can be used with max_replicas only, so the remaining fields (replica_limits only) should not be used with prefer_local. that would conflict with the example from the issue. if it is not -- no problem

Comment thread netmap/types.proto
Comment thread netmap/types.proto
@cthulhu-rider cthulhu-rider merged commit ad519d0 into master Feb 26, 2026
3 checks passed
@cthulhu-rider cthulhu-rider deleted the initial-placement branch February 26, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants