Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new “Soytify” metadata provider, updates core plugin types and imports, and removes the legacy nuclear identity and remote‐playlists functionality throughout the app.
- Introduce
SoytifyMetaProviderand register “Soytify” in the plugin types - Remove all nuclear identity, remote playlists, and user‐panel code (selectors, reducers, actions, containers, and tests)
- Update import paths for
getImageSetand clean up an unused ESLint disable
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/plugins/plugins.types.ts | Add Soytify to SearchResultsSource and reposition source field |
| packages/core/src/plugins/metaProvider.ts | Remove obsolete ESLint disable comment |
| packages/core/src/plugins/meta/spotify.ts | Update getImageSet import path |
| packages/core/src/plugins/meta/soytify/soytify.ts | Add new SoytifyMetaProvider |
| packages/app/test/storeBuilders.ts | Remove remotePlaylists and nuclear identity builders |
| packages/app/app/selectors/playlists.ts | Drop remotePlaylists selector |
| packages/app/app/selectors/nuclear.ts | Remove nuclear selectors |
| packages/app/app/reducers/playlists.ts | Remove remotePlaylists from store class |
| packages/app/app/reducers/nuclear/index.ts | Delete nuclear reducer |
| packages/app/app/reducers/nuclear/identity.ts | Delete nuclear identity reducer |
| packages/app/app/reducers/index.ts | Remove nuclear from rootReducer |
| packages/app/app/containers/UserPanelContainer/index.tsx | Remove entire UserPanelContainer |
| packages/app/app/containers/UserPanelContainer/*.test.tsx | Remove all UserPanelContainer tests |
| packages/app/app/containers/UserPanelContainer/*.tsx | Remove NuclearSignIn/SignUpForm containers |
| packages/app/app/containers/PlaylistsContainer/hooks.ts | Remove useRemotePlaylists hook |
| packages/app/app/containers/PlaylistsContainer/*.test.tsx | Remove remote‐playlists tests |
| packages/app/app/actions/playlists.ts | Remove remote playlists actions and imports |
| packages/app/app/actions/nuclear/identity.ts | Delete nuclear identity actions |
| packages/app/app/actions/actionTypes.ts | Remove remote‐playlists action types |
Comments suppressed due to low confidence (3)
packages/core/src/plugins/plugins.types.ts:11
- [nitpick] The new enum member
Soytifymay be confusingly similar toSpotify. Consider renaming it or adding a comment to clarify it’s a distinct source.
Soytify = 'Soytify',
packages/core/src/plugins/metaProvider.ts:38
- Removing this disable may reintroduce lint errors on unused abstract methods. Either implement or re-add the eslint disable if the stub is still needed.
// eslint-disable-next-line @typescript-eslint/no-unused-vars
packages/core/src/plugins/meta/soytify/soytify.ts:1
- New
SoytifyMetaProvideris introduced without any accompanying unit tests. Consider adding tests to validate its search and fetch methods.
import { SoytifyClientProvider } from '../../../rest/soytify/soytify-partners-api';
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
- Coverage 67.81% 66.26% -1.56%
==========================================
Files 379 375 -4
Lines 7747 7730 -17
Branches 635 676 +41
==========================================
- Hits 5254 5122 -132
- Misses 1969 2046 +77
- Partials 524 562 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.