Add support for ImageSteam and BuildConfig objects#111
Merged
Conversation
4 tasks
jmaupetit
force-pushed
the
add-support-for-bc-is
branch
2 times, most recently
from
42855ef to
0a21e0a
Compare
jmaupetit
changed the title
sampaccoud
reviewed
Sep 3, 2018
sampaccoud
approved these changes
Sep 4, 2018
Until now, BuildConfiguration and ImageStream objects were not required. Now that we need to add APM and customize images on a per-client basis, using the aforementionned objects seems the more relevant solution.
We now use custom image build for edxapp using ImageStream and BuildConfig objects.
Service pods are now based on a locally built image instead of DockerHub's raw image. This allows us to add project-specific contrains or customization.
jmaupetit
force-pushed
the
add-support-for-bc-is
branch
from
afa8309 to
03f2f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Until now, BuildConfiguration and ImageStream objects were not required. Now that we need to add APM and customize images on a per-client basis, using the aforementioned objects seems the more relevant solution.
nota bene:
Proposal
ImageStreamandBuildConfigobjectsedxapp(lms + cms)richie(app)