feat: simplify MongoDB initialization in docker-compose#3634
Open
AchrefHemissi wants to merge 3 commits intoopenimsdk:mainfrom
Open
feat: simplify MongoDB initialization in docker-compose#3634AchrefHemissi wants to merge 3 commits intoopenimsdk:mainfrom
AchrefHemissi wants to merge 3 commits intoopenimsdk:mainfrom
Conversation
- Replace complex inline bash script with dedicated init script - Use MongoDB built-in /docker-entrypoint-initdb.d/ mechanism - Create scripts/mongo-init.sh for user creation - Improve readability and maintainability Fixes openimsdk#3632
AchrefHemissi
requested review from
FGadvancer,
skiffer-git and
withchao
as code owners
pull-request-size
bot
added
the
size/M
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request simplifies the MongoDB initialization process in docker-compose by replacing an inline bash script with a dedicated initialization script that leverages MongoDB's built-in /docker-entrypoint-initdb.d/ mechanism.
Key Changes:
- Created
scripts/mongo-init.shto handle OpenIM user creation in MongoDB - Simplified MongoDB service configuration in
docker-compose.ymlby removing complex inline bash commands - Converted the
wiredTigerCacheSizeGBfrom an environment variable to a command-line argument
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scripts/mongo-init.sh | New initialization script for creating MongoDB OpenIM user with proper authentication |
| docker-compose.yml | Simplified MongoDB service configuration by using dedicated init script, cleaned up Redis command formatting, and removed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AchrefHemissi
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🅰 Please add the issue ID after "Fixes #"
Fixes #3632