OCPBUGS-23746: apiservice: Add retry to API services checks#2148
OCPBUGS-23746: apiservice: Add retry to API services checks#2148tchap wants to merge 1 commit intoopenshift:masterfrom
Conversation
checkDiscoveryForByAPIServices now performs 3 attempts to pass the check, each with 10-second timeout, 5-second backoff in between.
|
@tchap: This pull request references Jira Issue OCPBUGS-23746, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tchap The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Even when a node is rebooting this problem should really just be a single request that fails while existing connections are reset and new connections are made through the load balancer? Or would this condition extend for the duration in which a given member is down? |
@sdodson I started with checking this job. I thought it stayed unavailable for 7 seconds, but now I can see it actually blipped twice. Once very short for like 150 ms with 503, the other for 1.5 seconds or so with context deadline exceeded. Hmm. |
checkDiscoveryForByAPIServicesnow performs 3 attempts to pass the check, each with 10-second timeout, 5-second backoff in between.