✨ controllercmd: add WithServingTLSConfig for programmatic TLS override on the health/metrics server#2149
✨ controllercmd: add WithServingTLSConfig for programmatic TLS override on the health/metrics server#2149zhujian7 wants to merge 1 commit intoopenshift:masterfrom
Conversation
Add ServingMinTLSVersion and ServingCipherSuites fields to ControllerCommandConfig, along with a chainable WithServingTLSConfig setter. In StartController(), apply these overrides to config.ServingInfo before passing it to builder.WithServer(), so that SetRecommendedHTTPServingInfoDefaults (which uses DefaultString) does not clobber them. This lets callers enforce a minimum TLS version (e.g. VersionTLS13) on the 8443 health/metrics server. 🤖 Generated with Claude Code Signed-off-by: zhujian <jiazhu@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ff8fbd2 to
c6a5902
Compare
|
@zhujian7: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
ServingMinTLSVersionandServingCipherSuitesfields toControllerCommandConfigwith a chainableWithServingTLSConfig(minTLSVersion, cipherSuites)setterStartController(), apply these overrides toconfig.ServingInfobeforebuilder.WithServer()so thatSetRecommendedHTTPServingInfoDefaults(which usesDefaultString) does not clobber themVersionTLS13) or custom cipher suites on the 8443 health/metrics serverRelated issue(s)
N/A
Testing
Added unit tests in
pkg/controller/controllercmd/cmd_test.gocovering:WithServingTLSConfigsets fields correctlyconfig.ServingInfobefore defaults are setServingInfoempty so defaults kick in normally🤖 Generated with Claude Code