[release-4.20] OCPBUGS-79370: Re-order logger setting to eliminate race condition by openshift-cherrypick-robot · Pull Request #5791 · openshift/machine-config-operator

openshift-cherrypick-robot · 2026-03-23T18:43:18Z

This is an automated cherry-pick of #5779

/assign openshift-cherrypick-robot

/cherrypick release-4.19

coderabbitai · 2026-03-23T18:43:25Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e23d88bd-d64a-45ee-a530-e756b08b800a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

isabella-janssen · 2026-03-25T13:57:38Z

/retitle [release-4.20] OCPBUGS-79370: Re-order logger setting to eliminate race condition

openshift-ci-robot · 2026-03-25T13:57:49Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-79370, which is invalid:

expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5779

/assign openshift-cherrypick-robot

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-03-25T13:59:06Z

/jira refresh

openshift-ci-robot · 2026-03-25T13:59:14Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-79370, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-78800 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-78800 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-03-27T15:33:55Z

/verified by @isabella-janssen

This PR was verified by launching a cluster with #5783 to force the race condition causing the bug to always occur.

Without this fix included, we see the error logs:

$ oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-9cnbc
I0327 13:49:26.910877       1 start.go:40] Version: machine-config-daemon-4.6.0-202006240615.p0-3791-gb762c22d-dirty (b762c22d0ca7964d76cae2e2fe6ebb8ba69162b8)
I0327 13:49:27.016421       1 start.go:51] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0327 13:49:27.016546       1 api.go:69] Launching server on :22624
I0327 13:49:27.016561       1 api.go:69] Launching server on :22623
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
	>  goroutine 62 [running]:
	>  runtime/debug.Stack()
	>  	/usr/lib/golang/src/runtime/debug/stack.go:26 +0x5e
	>  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:60 +0xcd
	>  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).Enabled(0xc0003c2c40, 0x0)
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:111 +0x32
	>  github.com/go-logr/logr.Logger.Info({{0x2c927b0?, 0xc0003c2c40?}, 0xc0007b6000?}, {0x2852401, 0x1f}, {0x0, 0x0, 0x0})
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/github.com/go-logr/logr/logr.go:276 +0x6e
	>  sigs.k8s.io/controller-runtime/pkg/certwatcher.(*CertWatcher).ReadCertificate(0xc0002782a0)
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:211 +0x29c
	>  sigs.k8s.io/controller-runtime/pkg/certwatcher.New({0x283d5d0, 0x14}, {0x283d5e4, 0x14})
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:71 +0x8f
	>  github.com/openshift/machine-config-operator/pkg/server.(*APIServer).Serve(0xc00002e190)
	>  	/go/src/github.com/openshift/machine-config-operator/pkg/server/api.go:77 +0x2c8
	>  created by main.runStartCmd in goroutine 1
	>  	/go/src/github.com/openshift/machine-config-operator/cmd/machine-config-server/start.go:59 +0x37e
I0327 13:53:15.739850       1 api.go:129] Pool "worker" requested by address:"10.0.83.75:22266" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"

With the fix included, there are no error logs:

$ oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-8bhkj
I0327 14:56:13.379806       1 start.go:44] Version: machine-config-daemon-4.6.0-202006240615.p0-3795-g2431a680-dirty (2431a680a7d306894f09f1eb18c5bc12e4c849b6)
I0327 14:56:13.884759       1 start.go:55] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0327 14:56:13.884873       1 api.go:68] Launching server on :22624
I0327 14:56:13.885249       1 api.go:68] Launching server on :22623
I0327 14:56:48.891552       1 certwatcher.go:211] "Updated current TLS certificate" logger="controller-runtime.certwatcher"
I0327 14:56:48.891792       1 certwatcher.go:133] "Starting certificate poll+watcher" logger="controller-runtime.certwatcher" interval="10s"
I0327 14:57:15.840314       1 api.go:127] Pool "worker" requested by address:"10.0.127.170:12150" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
E0327 14:57:15.897707       1 cluster_server.go:149] Could not get kubeconfig data: configmap "kubeconfig-data" not found
I0327 14:57:21.339836       1 api.go:127] Pool "worker" requested by address:"10.0.127.170:15354" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
E0327 14:57:21.347683       1 cluster_server.go:149] Could not get kubeconfig data: configmap "kubeconfig-data" not found
I0327 15:17:41.723270       1 api.go:127] Pool "worker" requested by address:"10.0.127.170:8790" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"

openshift-ci-robot · 2026-03-27T15:34:08Z

@isabella-janssen: This PR has been marked as verified by @isabella-janssen.

Details

In response to this:

/verified by @isabella-janssen

This PR was verified by launching a cluster with #5783 to force the race condition causing the bug to always occur.

Without this fix included, we see the error logs:

$ oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-9cnbc
I0327 13:49:26.910877       1 start.go:40] Version: machine-config-daemon-4.6.0-202006240615.p0-3791-gb762c22d-dirty (b762c22d0ca7964d76cae2e2fe6ebb8ba69162b8)
I0327 13:49:27.016421       1 start.go:51] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0327 13:49:27.016546       1 api.go:69] Launching server on :22624
I0327 13:49:27.016561       1 api.go:69] Launching server on :22623
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
  >  goroutine 62 [running]:
  >  runtime/debug.Stack()
  >  	/usr/lib/golang/src/runtime/debug/stack.go:26 +0x5e
  >  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:60 +0xcd
  >  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).Enabled(0xc0003c2c40, 0x0)
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:111 +0x32
  >  github.com/go-logr/logr.Logger.Info({{0x2c927b0?, 0xc0003c2c40?}, 0xc0007b6000?}, {0x2852401, 0x1f}, {0x0, 0x0, 0x0})
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/github.com/go-logr/logr/logr.go:276 +0x6e
  >  sigs.k8s.io/controller-runtime/pkg/certwatcher.(*CertWatcher).ReadCertificate(0xc0002782a0)
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:211 +0x29c
  >  sigs.k8s.io/controller-runtime/pkg/certwatcher.New({0x283d5d0, 0x14}, {0x283d5e4, 0x14})
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:71 +0x8f
  >  github.com/openshift/machine-config-operator/pkg/server.(*APIServer).Serve(0xc00002e190)
  >  	/go/src/github.com/openshift/machine-config-operator/pkg/server/api.go:77 +0x2c8
  >  created by main.runStartCmd in goroutine 1
  >  	/go/src/github.com/openshift/machine-config-operator/cmd/machine-config-server/start.go:59 +0x37e
I0327 13:53:15.739850       1 api.go:129] Pool "worker" requested by address:"10.0.83.75:22266" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"

With the fix included, there are no error logs:

$ oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-8bhkj
I0327 14:56:13.379806       1 start.go:44] Version: machine-config-daemon-4.6.0-202006240615.p0-3795-g2431a680-dirty (2431a680a7d306894f09f1eb18c5bc12e4c849b6)
I0327 14:56:13.884759       1 start.go:55] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0327 14:56:13.884873       1 api.go:68] Launching server on :22624
I0327 14:56:13.885249       1 api.go:68] Launching server on :22623
I0327 14:56:48.891552       1 certwatcher.go:211] "Updated current TLS certificate" logger="controller-runtime.certwatcher"
I0327 14:56:48.891792       1 certwatcher.go:133] "Starting certificate poll+watcher" logger="controller-runtime.certwatcher" interval="10s"
I0327 14:57:15.840314       1 api.go:127] Pool "worker" requested by address:"10.0.127.170:12150" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
E0327 14:57:15.897707       1 cluster_server.go:149] Could not get kubeconfig data: configmap "kubeconfig-data" not found
I0327 14:57:21.339836       1 api.go:127] Pool "worker" requested by address:"10.0.127.170:15354" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
E0327 14:57:21.347683       1 cluster_server.go:149] Could not get kubeconfig data: configmap "kubeconfig-data" not found
I0327 15:17:41.723270       1 api.go:127] Pool "worker" requested by address:"10.0.127.170:8790" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-03-27T15:34:24Z

/retest-required

djoshy · 2026-03-27T15:35:25Z

/lgtm

/label backport-risk-assessed

openshift-ci · 2026-03-27T15:35:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-03-27T20:04:18Z

/retest-required

Remaining retests: 0 against base HEAD 3ca2b86 and 2 for PR HEAD a9b02a6 in total

isabella-janssen · 2026-03-27T20:43:57Z

/retest-required

isabella-janssen · 2026-03-27T21:47:26Z

/retest-required

isabella-janssen · 2026-03-27T23:20:15Z

/retest-required

openshift-ci · 2026-03-28T05:43:16Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-ocl	`a9b02a6`	link	false	`/test e2e-gcp-op-ocl`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-03-28T07:04:16Z

/retest-required

Remaining retests: 0 against base HEAD 8284040 and 1 for PR HEAD a9b02a6 in total

openshift-ci-robot · 2026-03-28T10:35:35Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-79370
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-79370 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #5779

/assign openshift-cherrypick-robot

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-03-28T10:36:21Z

@openshift-cherrypick-robot: new pull request created: #5822

Details

In response to this:

This is an automated cherry-pick of #5779

/assign openshift-cherrypick-robot

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

server: re-order logger setting

a9b02a6

openshift-cherrypick-robot self-assigned this Mar 23, 2026

openshift-cherrypick-robot mentioned this pull request Mar 23, 2026

[release-4.21] OCPBUGS-78800: Re-order logger setting to eliminate race condition #5779

Merged

openshift-ci bot requested review from RishabhSaini and umohnani8 March 23, 2026 18:44

openshift-ci bot changed the title ~~[release-4.20] OCPBUGS-78800: Re-order logger setting to eliminate race condition~~ [release-4.20] OCPBUGS-79370: Re-order logger setting to eliminate race condition Mar 25, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2026

openshift-ci bot requested a review from sergiordlr March 25, 2026 13:59

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 27, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 27, 2026

openshift-ci bot assigned anuragthehatter, imatza-rh, lyman9966, mhanss, ptalgulk01, rbbratta, rioliu-rh and sergiordlr Mar 27, 2026

openshift-ci bot assigned zhaozhanqi Mar 27, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2026

openshift-merge-bot bot merged commit 020d313 into openshift:release-4.20 Mar 28, 2026
15 of 16 checks passed

openshift-cherrypick-robot mentioned this pull request Mar 28, 2026

[release-4.19] OCPBUGS-81282: Re-order logger setting to eliminate race condition #5822

Open

Conversation

openshift-cherrypick-robot commented Mar 23, 2026

Uh oh!

coderabbitai bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

isabella-janssen commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

isabella-janssen commented Mar 25, 2026

Uh oh!

openshift-ci-robot commented Mar 25, 2026

Uh oh!

isabella-janssen commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

isabella-janssen commented Mar 27, 2026

Uh oh!

djoshy commented Mar 27, 2026

Uh oh!

openshift-ci bot commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

isabella-janssen commented Mar 27, 2026

Uh oh!

isabella-janssen commented Mar 27, 2026

Uh oh!

isabella-janssen commented Mar 27, 2026

Uh oh!

openshift-ci bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2026

Uh oh!

openshift-cherrypick-robot commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

openshift-ci bot commented Mar 28, 2026 •

edited

Loading