OCPBUGS-57473: create digest configmap without oc binary#5794
OCPBUGS-57473: create digest configmap without oc binary#5794cheesesashimi wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
@cheesesashimi: This pull request references Jira Issue OCPBUGS-57473, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1832f84 to
197e54b
Compare
|
/test e2e-gcp-op-ocl |
|
/test unit |
|
@cheesesashimi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
This is a different implementation for the problem discussed in #5313 . Instead of including the
ocbinary in the MCO image or extracting it from the build process, this does the following:create-digest-configmapsubcommand onto themachine-os-buildercommand.oc.This should result in a smaller overall MCO image as well as eliminating the need to use the
ocbinary.- How to verify it
The image build process should continue to work as-is, meaning that the current E2E test suites should be able to verify it.
- Description for the changelog
Create digest configmap without oc binary