MCO-2135: Add test for OSStream labeling of Machines, MachineSets, and ControlPaneMachineSets#5814
MCO-2135: Add test for OSStream labeling of Machines, MachineSets, and ControlPaneMachineSets#5814isabella-janssen wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdded a new Ginkgo test file that validates OS stream labels on cluster Machines/MachineSets/ControlPlaneMachineSets, and refactored MachineSet listing by introducing a shared Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-1of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/35a7b540-294d-11f1-8cd1-7fb01abd20c1-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-2of3 openshift/installer#10426 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3dd38910-294d-11f1-9571-7157764fec29-0 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4078df80-294d-11f1-8557-4a5fd3d7401d-0 |
isabella-janssen
force-pushed
the
mco-2135
branch
from
caab48a to
42835fd
Compare
isabella-janssen
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@isabella-janssen: This pull request references MCO-2135 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-1of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b8905350-29e2-11f1-8f68-8962acc64efe-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-2of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bd4c7bd0-29e2-11f1-8fc3-4f4c030185fd-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c027d660-29e2-11f1-935c-b9dc41dc781e-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-1of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c5965ef0-29e2-11f1-85cf-d80b528c994f-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-2of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cc9dd700-29e2-11f1-977f-6b9402d0016e-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cff69ef0-29e2-11f1-9bd6-784df20e3dfc-0 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/93c91560-29e3-11f1-97f8-341a63c0771b-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview-2of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96a4e520-29e3-11f1-8d7f-b3f59b7b80a6-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/98fedab0-29e3-11f1-91d8-16af775296ab-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview-1of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c3c70b40-29e4-11f1-860b-45e0d5a86c49-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview-2of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6703240-29e4-11f1-9d7d-eb96f9b1711c-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c8c34a00-29e4-11f1-9def-3c753f6a430b-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview-1of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d72207d0-29e4-11f1-9014-51eef2ca8f10-0 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview-2of3 openshift/installer#10426 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-metal-ipi-ovn-dualstack-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ddd67de0-29e4-11f1-828d-3e911ff36d24-0 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e0570e40-29e4-11f1-8425-757befb7bd57-0 |
|
Instead of a random machine/machineset, could we just check all of them? The methodology seems sound to me! |
We can, I figured if one random one had it, all of them would. That being said, the test is really quick and this shouldn't add really much time or effort so I'll make that change. Thank you for the suggestion @djoshy! |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-gcp-mco-disruptive-techpreview-1of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6520be40-29ff-11f1-948f-e63d56c967e0-0 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/extended/boot_image.go`:
- Around line 90-96: getAllMachineSets currently returns a MachineSetList
without validating it contains items which can cause getRandomMachineSet (which
calls rand.Intn) to panic; update getAllMachineSets to assert the result is
non-nil and has at least one item (e.g., using
o.Expect(machineSets).NotTo(o.BeNil()) and
o.Expect(machineSets.Items).NotTo(o.BeEmpty()) or equivalent Gomega checks)
before returning so the test fails fast on empty MachineSet lists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ecbc8c85-e829-4c81-a867-c20dbca8cd7e
📒 Files selected for processing (2)
test/extended/boot_image.gotest/extended/osImageStream.go
isabella-janssen
force-pushed
the
mco-2135
branch
from
5cd09ea to
2786e43
Compare
… controlPaneMachineSets
isabella-janssen
force-pushed
the
mco-2135
branch
from
2786e43 to
55bab2c
Compare
|
@isabella-janssen: This pull request references MCO-2135 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
/payload-job-with-prs periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-azure-mco-disruptive-techpreview-3of3 openshift/installer#10426 |
|
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3a0070e0-2a25-11f1-8542-89d5232c8f68-0 |
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
- What I did
This adds a test to ensure the labels being added in openshift/installer#10426 are present on all expected resources in a cluster.
- How to verify it
These tests should pass when run in a tech preview cluster including openshift/installer#10426.
- Description for the changelog
MCO-2135: add e2e test for OSStream labels on machines, machineSets, and controlPaneMachineSets