CNV-66552:Mimic split screen behavior and drag-and-drop behavior in N… by aviavissar · Pull Request #159 · openshift/nmstate-console-plugin

aviavissar · 2026-01-26T09:34:51Z

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

fix resize form
the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:

Video_2026-01-26_11-42-45.mp4

after fix :

Video_2026-01-26_11-02-04.mp4

fix Design

openshift-ci-robot · 2026-01-26T09:34:56Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-01-26T09:35:49Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aviavissar
Once this PR has been reviewed and has the lgtm label, please assign metalice for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-01-26T09:36:01Z

Hi @aviavissar. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-01-26T09:37:06Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-26T09:37:48Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-26T09:38:06Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-26T09:38:54Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-26T09:46:09Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pcbailey

The design leaves the title bar visible with the wizard appearing before it. Can you place the drawer beneath the title bar?

Design doc: https://docs.google.com/document/d/1_CB2VknL427uZrbswV113CIfCGZa8OtvVyDkZUgsO54/edit?tab=t.0#heading=h.t0q1cztjdow9

...views/nodenetworkconfiguration/components/TopologySidebar/InterfaceDrawer/TopologyDrawer.tsx

src/views/nodenetworkconfiguration/components/TopologyToolbar/TopologyToolbar.scss

upalatucci · 2026-01-30T08:21:59Z

/ok-to-test

src/nmstate-types/react-resize-panel.d.ts

src/views/nodenetworkconfiguration/Topology.tsx

src/views/nodenetworkconfiguration/components/TopologyToolbar/TopologyToolbar.tsx

src/views/nodenetworkconfiguration/components/TopologySidebar/CustomDrawer.tsx

src/views/nodenetworkconfiguration/components/TopologySidebar/CreatePolicyDrawer.tsx

...views/nodenetworkconfiguration/components/TopologySidebar/InterfaceDrawer/TopologyDrawer.tsx

metalice · 2026-02-02T14:16:27Z

@aviavissar I dont see resizeing or form in the demo?

yfrimanm · 2026-02-02T15:47:47Z

@aviavissar The drawer is placed on top of the title bar which isn't what is shown in the design doc. The title is also not aligned to the left but looks more pushed to the center. https://docs.google.com/document/d/1_CB2VknL427uZrbswV113CIfCGZa8OtvVyDkZUgsO54/edit?pli=1&tab=t.0#heading=h.t0q1cztjdow9

openshift-ci-robot · 2026-02-03T21:25:17Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-03T21:26:50Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

aviavissar · 2026-02-03T21:28:31Z

it on purpose. so u wont create from when u in the middle of creating the first one form - let discuses that @yfrimanm

openshift-ci-robot · 2026-02-03T21:29:48Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

metalice · 2026-02-04T12:39:39Z

src/views/nodenetworkconfiguration/Topology.tsx

+        >
+          <VisualizationSurface state={queryParams} />
+          <Popover
+            aria-label="Node network configuration graph legend"


translation?

upalatucci · 2026-02-06T14:34:16Z

src/views/nodenetworkconfiguration/components/TopologySidebar/CreatePolicyDrawer.tsx


 type CreatePolicyDrawerProps = {
-  onClose?: () => void;
+  onClose?: (bool: boolean) => void;


i dont like the name bool. Please find a meaningful name

upalatucci · 2026-02-06T14:34:30Z

src/views/nodenetworkconfiguration/components/TopologyToolbar/TopologyToolbar.tsx

  selectedNodeFilters: string[];
  setSelectedNodeFilters: Dispatch<SetStateAction<string[]>>;
  nodeNames: string[];
+  onOpen: (bool: boolean) => void;


openshift-ci-robot · 2026-02-09T01:23:41Z

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…NCP wizard/topology view

openshift-ci · 2026-02-09T03:23:49Z

@aviavissar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-tests	`ee74c48`	link	true	`/test e2e-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2026

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026

openshift-ci bot requested review from metalice and tnisan January 26, 2026 09:35

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 26, 2026

aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 8ce5fd0 to 895a588 Compare January 26, 2026 10:22

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026

pcbailey reviewed Jan 26, 2026

View reviewed changes

...views/nodenetworkconfiguration/components/TopologySidebar/InterfaceDrawer/TopologyDrawer.tsx Outdated Show resolved Hide resolved

src/views/nodenetworkconfiguration/components/TopologyToolbar/TopologyToolbar.scss Outdated Show resolved Hide resolved

aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 895a588 to 7b0d191 Compare January 28, 2026 14:34

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2026

aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 7b0d191 to 83cc05f Compare February 1, 2026 12:46

metalice reviewed Feb 2, 2026

View reviewed changes

src/nmstate-types/react-resize-panel.d.ts Outdated Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

src/views/nodenetworkconfiguration/Topology.tsx Outdated Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

src/views/nodenetworkconfiguration/Topology.tsx Outdated Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

src/views/nodenetworkconfiguration/components/TopologyToolbar/TopologyToolbar.tsx Outdated Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

src/views/nodenetworkconfiguration/components/TopologyToolbar/TopologyToolbar.tsx Outdated Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

src/views/nodenetworkconfiguration/components/TopologySidebar/CustomDrawer.tsx Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

src/views/nodenetworkconfiguration/components/TopologySidebar/CreatePolicyDrawer.tsx Outdated Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

...views/nodenetworkconfiguration/components/TopologySidebar/InterfaceDrawer/TopologyDrawer.tsx Outdated Show resolved Hide resolved

metalice reviewed Feb 2, 2026

View reviewed changes

...views/nodenetworkconfiguration/components/TopologySidebar/InterfaceDrawer/TopologyDrawer.tsx Outdated Show resolved Hide resolved

aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 83cc05f to d6101fa Compare February 3, 2026 21:33

metalice reviewed Feb 4, 2026

View reviewed changes

upalatucci reviewed Feb 6, 2026

View reviewed changes

aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from d6101fa to 00e270d Compare February 9, 2026 01:13

aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 00e270d to 5b4cb67 Compare February 9, 2026 01:36

CNV-66552:Mimic split screen behavior and drag-and-drop behavior in N…

ee74c48

…NCP wizard/topology view

aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 5b4cb67 to ee74c48 Compare February 9, 2026 01:52

Conversation

aviavissar commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

Uh oh!

openshift-ci-robot commented Jan 26, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

Uh oh!

openshift-ci bot commented Jan 26, 2026

Uh oh!

openshift-ci bot commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1fix resize form

Uh oh!

openshift-ci-robot commented Jan 26, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1fix resize form

Uh oh!

openshift-ci-robot commented Jan 26, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

1fix resize form

Uh oh!

openshift-ci-robot commented Jan 26, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

Uh oh!

openshift-ci-robot commented Jan 26, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

Uh oh!

pcbailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

upalatucci commented Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metalice commented Feb 2, 2026

Uh oh!

yfrimanm commented Feb 2, 2026

Uh oh!

openshift-ci-robot commented Feb 3, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

Uh oh!

openshift-ci-robot commented Feb 3, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

Uh oh!

aviavissar commented Feb 3, 2026

Uh oh!

openshift-ci-robot commented Feb 3, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

Uh oh!

metalice Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

upalatucci Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

upalatucci Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Feb 9, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

aviavissar commented Jan 26, 2026 •

edited

Loading

openshift-ci-robot commented Jan 26, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 26, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 26, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 26, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 26, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 26, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 3, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 3, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 3, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 9, 2026 •

edited by openshift-ci bot

Loading