-
Notifications
You must be signed in to change notification settings - Fork 47
NO-ISSUE: Synchronize From Upstream Repositories #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
openshift-bot
wants to merge
96
commits into
openshift:main
Choose a base branch
from
openshift-bot:synchronize-upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
0e70fe3
tests: address CodeRabbit review comments from downstream PR (#2672)
tmshort e12d90b
:bug: Fix catalogd ha readiness (#2674)
tmshort cadb7a7
:seedling: Bump github.com/google/go-containerregistry (#2677)
dependabot[bot] aa70192
:seedling: Bump marocchino/sticky-pull-request-comment (#2676)
dependabot[bot] ee337de
:seedling: Bump github.com/cert-manager/cert-manager (#2678)
dependabot[bot] 4ce4bab
adds support for parsing explicit `pkg.Release` field (#2543)
rashmigottipati 682225b
Merge branch 'main' into synchronize
7d21a82
UPSTREAM: <carry>: Add OpenShift specific files
dtfranz f3e56bb
UPSTREAM: <carry>: Add new tests for single/own namespaces install modes
camilamacedo86 186fcde
UPSTREAM: <carry>: Upgrade OCP image from 4.20 to 4.21
camilamacedo86 eb32541
UPSTREAM: <carry>: [Default Catalog Tests] - Change logic to get ocp …
camilamacedo86 cb83f9a
UPSTREAM: <carry>: Update OCP catalogs to v4.21
tmshort af36af1
UPSTREAM: <carry>: support singleown cases in disconnected
kuiwang02 29aca7e
UPSTREAM: <carry>: fix cases 81696 and 74618 for product code changes
kuiwang02 3bb11a5
UPSTREAM: <carry>: Define Default timeouts and apply their usage accr…
camilamacedo86 f5450db
UPSTREAM: <carry>: Update to new feature-gate options in helm
tmshort 85d1491
UPSTREAM: <carry>: Fix flake for single/own ns tests by ensuring uniq…
camilamacedo86 93b275e
UPSTREAM: <carry>: [OTE]: Enhance single/own ns based on review comme…
camilamacedo86 849f23b
UPSTREAM: <carry>: Update OwnSingle template to use spec.config.inlin…
kuiwang02 f7e52cb
UPSTREAM: <carry>: [OTE]: Add webhook cleanup validation on extension…
camilamacedo86 6e1e1dd
UPSTREAM: <carry>: Add [OTP] to migrated cases
kuiwang02 7acbceb
UPSTREAM: <carry>: [OTE]: Upgrade dependencies used
camilamacedo86 e4637e8
UPSTREAM: <carry>: fix(OTE): fix OpenShift Kubernetes replace version…
camilamacedo86 fd85194
UPSTREAM: <carry>: [Default Catalog Tests] Upgrade go 1.24.6 and depe…
camilamacedo86 5647b1b
UPSTREAM: <carry>: add disconnected environment support with custom p…
kuiwang02 ad6f8b1
UPSTREAM: <carry>: migrate jiazha test cases to OTE
jianzhangbjz 90c816e
UPSTREAM: <carry>: migrate clustercatalog case to ote
Xia-Zhao-rh fdd98cc
UPSTREAM: <carry>: migrate olmv1 QE stress cases
kuiwang02 1f5dd0e
UPSTREAM: <carry>: Use busybox/httpd to simulate probes
tmshort 6702ef8
UPSTREAM: <carry>: migrate olmv1 QE cases
Xia-Zhao-rh de0eb32
UPSTREAM: <carry>: add agent for olmv1 qe cases
kuiwang02 cc042c2
UPSTREAM: <carry>: Disable upstream PodDisruptionBudget
tmshort 9f60f9b
UPSTREAM: <carry>: Add AGENTS.md for AI code contributions
rashmigottipati d83e6e9
UPSTREAM: <carry>: address review comments through addl prompts
rashmigottipati dc1e710
UPSTREAM: <carry>: addressing some more review comments
rashmigottipati 629583c
UPSTREAM: <carry>: remove DCO line
rashmigottipati 444f952
UPSTREAM: <carry>: migrate bandrade test cases to OTE
bandrade 2ff0e24
UPSTREAM: <carry>: update metadata
bandrade 33919c1
UPSTREAM: <carry>: remove originalName
bandrade c4ab8c5
UPSTREAM: <carry>: update 80458's timeout to 180s
jianzhangbjz cebc002
UPSTREAM: <carry>: update 83026 to specify the clustercatalog
jianzhangbjz 493846e
UPSTREAM: <carry>: Update to golang 1.25 and ocp 4.22
oceanc80 25985c7
UPSTREAM: <carry>: Use oc client for running e2e tests
pedjak 9e134b2
UPSTREAM: <carry>: Run upstream e2e tests tagged with `@catalogd-update`
pedjak 1535208
UPSTREAM: <carry>: enhance case to make it more stable
kuiwang02 99976a6
UPSTREAM: <carry>: add service account to curl job
ehearne-redhat 3c8842c
UPSTREAM: <carry>: move sa creation out of buildCurlJob()
ehearne-redhat b96392c
UPSTREAM: <carry>: comment out delete service account
ehearne-redhat 45d86ea
UPSTREAM: <carry>: move defercleanup for sa for LIFO
ehearne-redhat fc6eb78
UPSTREAM: <carry>: add polling so job fully deleted before proceed
ehearne-redhat d22f0e0
UPSTREAM: <carry>: Revert "Merge pull request #594 from ehearne-redha…
sosiouxme 7c43773
UPSTREAM: <carry>: Remove openshift-redhat-marketplace catalog tests
camilamacedo86 ae516ab
UPSTREAM: <carry>: config watchnamespace cases
kuiwang02 8b1a72c
UPSTREAM: <carry>: enhance ocp-79770
Xia-Zhao-rh 991c919
UPSTREAM: <carry>: upgrade version support case
kuiwang02 a50f08c
UPSTREAM: <carry>: Remove installed condition check from auth preflig…
8f1001f
UPSTREAM: <carry>: Add openshift/api dependency
77cc4db
UPSTREAM: <carry>: Add boxcutter specific preflight auth test
c0b34e9
UPSTREAM: <carry>: adjust watchnamespace case based on change
kuiwang02 ffa4699
UPSTREAM: <carry>: fix(ote): Use as operator-controller dep from root…
camilamacedo86 88e2a82
UPSTREAM: <carry>: add 83979 automation
bandrade 22467f4
UPSTREAM: <carry>: add 85889 automation
bandrade 42172e2
UPSTREAM: <carry>: Update test-operator startup script to fix pod pro…
7ee6b80
UPSTREAM: <carry>: Fix up own-namespace invalid configuration test
70dde62
UPSTREAM: <carry>: Preflight tests use in-cluster catalog and bundles…
camilamacedo86 c0a5385
UPSTREAM: <carry>: adjust sa and permission test cases per new change…
kuiwang02 6591369
UPSTREAM: <carry>: Update OCP catalogs to v4.22
camilamacedo86 a2ec03b
UPSTREAM: <carry>: chore(OTE and Default Catalog Tests) Update go and…
camilamacedo86 67db790
UPSTREAM: <carry>: fix 83026 for TP cluster
jianzhangbjz 21ebeda
UPSTREAM: <carry>: serviceAccount validation unified across all runtimes
kuiwang02 55b498f
UPSTREAM: <carry>: Fix OLMv1 test operator to listen on IPv6
stbenjam 548e5e9
UPSTREAM: <carry>: Increase install timeout and add diagnostic loggin…
camilamacedo86 a914c7d
UPSTREAM: <carry>: add service account to curl job
ehearne-redhat f5efc96
UPSTREAM: <carry>: update OCP-75441 to support multi-arch
jianzhangbjz 683c374
UPSTREAM: <carry>: deployment config cases
kuiwang02 bea443c
UPSTREAM: <carry>: Add OTE tests for OLMv1 DeploymentConfig support
tmshort 9dafe8c
UPSTREAM: <carry>: Update openshift/api and client-go
tmshort 4702c4a
UPSTREAM: <carry>: Add boxcutter tests
camilamacedo86 ff1c31e
UPSTREAM: <carry>: enhance QE cases
Xia-Zhao-rh 8751178
UPSTREAM: <carry>: Update quay-operator version to one containing arm…
dtfranz cd7e796
UPSTREAM: <carry>: verify volume/volumeMount override
kuiwang02 03d2068
UPSTREAM: <carry>: Add long-duration test script and documents
jianzhangbjz 3a11e34
UPSTREAM: <carry>: Update grpc in default-catalog-consistency tests
tmshort e99a78c
UPSTREAM: <carry>: Rename ClusterExtensionRevision to ClusterObjectSe…
camilamacedo86 5aa3e1e
UPSTREAM: <carry>: Skip incompatible operator test when Boxcutter use…
camilamacedo86 0a2e8a2
UPSTREAM: <carry>: add ocp-87557
bandrade c95acbd
UPSTREAM: <carry>: Add fgiudici as reviewer
fgiudici 700ebba
UPSTREAM: <carry>: Remove skip for incompatible operator check after …
camilamacedo86 d559200
UPSTREAM: <carry>: Test empty affinity erasure and cleanup
kuiwang02 2837680
UPSTREAM: <carry>: Fix boxcutter finalizer ResourceNames in prefligh…
camilamacedo86 1628a22
UPSTREAM: <carry>: Expand OTE docs with more comprehensive details
camilamacedo86 2c20aef
UPSTREAM: <carry>: Disable upstream TLSProfile tests
tmshort 2fec97b
UPSTREAM: <carry>: OTE: Simplify by remove option to configure tests …
camilamacedo86 692836d
UPSTREAM: <drop>: go mod vendor
9245e47
UPSTREAM: <drop>: remove upstream GitHub configuration
b09c936
UPSTREAM: <drop>: configure the commit-checker
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaxLength=20introduces a schema/runtime mismatch that can block reconciliation.Line 489 caps
status.install.bundle.releaseto 20 chars, but release parsing/propagation paths accept valid longer values. A valid release string over 20 chars would fail status validation at write time instead of being handled deterministically earlier.💡 Proposed fix (align API with current parser behavior)
- // +kubebuilder:validation:MaxLength=20 // +kubebuilder:validation:XValidation:rule="self.matches(\"^$|^(0|[1-9][0-9]*|[0-9]*[A-Za-z-][0-9A-Za-z-]*)(\\\\.(0|[1-9][0-9]*|[0-9]*[A-Za-z-][0-9A-Za-z-]*))*$\")",message="release must be empty or consist of dot-separated identifiers (numeric without leading zeros, or alphanumeric)" Release *string `json:"release,omitempty"`If the 20-char cap is required, enforce that same limit at all ingestion points before status assignment, and return a clear validation error there.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grokspawn @rashmigottipati do we care about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.