[matjaz-test3] [AI-FSSDK] (DO NOT REVIEW) [FSSDK-12248] Increase max retry time interval to 3 seconds#387
Open
[matjaz-test3] [AI-FSSDK] (DO NOT REVIEW) [FSSDK-12248] Increase max retry time interval to 3 seconds#387
Conversation
…val to 3 seconds Updated ODP_EVENT_MANAGER MAX_RETRY_INTERVAL from 1.0 to 3.0 seconds to allow longer retry intervals during network issues. This change affects the exponential backoff retry logic which now caps at 3 seconds instead of 1 second. Changes: - lib/optimizely/helpers/constants.rb: Updated MAX_RETRY_INTERVAL constant - spec/odp/odp_event_manager_spec.rb: Updated test expectations for new cap Quality Assurance Results: - Status: SUCCESS (adapted changes to upstream refactoring) - Iterations: 1/5 (smart exit - perfect on first try) - Tests: 26/26 passed - Review: Approved (0 critical, 0 warnings) - Test coverage: Comprehensive exponential backoff validation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increased the maximum retry interval for ODP event manager from 1 second to 3 seconds to provide better resilience during network issues.
Changes
MAX_RETRY_INTERVALconstant from 1.0 to 3.0 secondsImplementation Details
This change works with the existing exponential backoff retry mechanism that was refactored in the upstream codebase. The retry intervals now progress as:
Quality Assurance
✅ Tests: 26/26 passed
✅ Code Review: Approved (0 critical issues, 0 warnings)
✅ QA Iterations: 1/5 (smart exit - perfect on first try)
Test Coverage
Jira Ticket
FSSDK-12248
🤖 Generated with Claude Code