Implement x-www-form-urlencoded validation#237
Open
ySnoopyDogy wants to merge 6 commits intopb33f:mainfrom
Open
Implement x-www-form-urlencoded validation#237ySnoopyDogy wants to merge 6 commits intopb33f:mainfrom
ySnoopyDogy wants to merge 6 commits intopb33f:mainfrom
Conversation
also added a validation for XML namespaces and prefix
Potentially closes pb33f#180
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 97.61% 97.79% +0.18%
==========================================
Files 56 60 +4
Lines 5240 5769 +529
==========================================
+ Hits 5115 5642 +527
- Misses 125 127 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was made on top of #214, and closes #180.
The same idea from the XML validation was used for URLEncoded. We convert the data into a JSON structure matching the types from the Schema, so we can validate the JSON structure against the OpenAPI schema.
Created a new interface
URLEncodedValidatorwith two functions for validating url encoded:ValidateURLEncodedStringandValidateURLEncodedStringWithVersion.Added a new option to ValidationOptions:
AllowURLEncodedBodyValidationto enable URL Encoded validations in request/response bodies (the default is false). Created a function WithURLEncodedBodyValidation to enable the new validator option.No breaking changes with the new code, as the updated function was internal, and the URL Encoded body validation setting is false by default.