pmlogger_daily: add disk size limit option and enforce archive purging #2475
+158
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@orasagar sorry I botched the build, but this is now fixed. Could you please rebase or pull latest commits from main, so we rerun the checks here and get a cleaner bill of health? |
Introduce a new -d/--disk option to pmlogger_daily.sh for specifying a maximum disk usage (in GB) for PCP_LOG_DIR. Added logic to check and enforce this limit by removing oldest archives when exceeded, to prevent disk overuse.
Refactored size-based archive culling logic in pmlogger_daily.sh for clarity and maintainability. Replaced boolean SIZE_LIMIT_FLAG with integer check, updated logic to be more robust, and moved purge logic to a separate function for better structure. Enhanced verbosity handling and archive size calculation.
Introduce -d/--disk option for setting a maximum total disk size for PCP archives. Update documentation and script logic to parse size values with K/M/G suffixes, enforce purging of oldest files when the limit is exceeded, and improve size reporting. This helps manage storage usage more effectively.
orasagar
force-pushed
the
pcp-cull_on_size
branch
from
62ba6fa to
bd19118
Compare
Contributor
Author
|
@kmcdonell I have successfully re-based my branch on top of the current main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce -d/--disk option for setting a maximum total disk size for PCP archives. Update documentation and script logic to parse size values with K/M/G suffixes, enforce purging of oldest files when the limit is exceeded, and improve size reporting. This helps manage storage usage more effectively.