Conversation
|
I forgot to add UPGRADING for |
|
php/php-src#20239 might also need to be incorporated |
Added in 4f86bb5
Changed in 3d7f6f5 |
|
Added in a288458. |
5369184 to
928e2f4
Compare
Girgias
left a comment
There was a problem hiding this comment.
Thank you for starting this! I left a lot of comments that I would like to have addressed. :)
| <simpara> | ||
| The <link linkend="object.wakeup">__wakeup()</link> magic method of | ||
| <interfacename>DateTimeInterface</interfacename>, | ||
| <classname>DateTime</classname>, <classname>DateTimeImmutable</classname>, | ||
| <classname>DateTimeZone</classname>, <classname>DateInterval</classname>, | ||
| and <classname>DatePeriod</classname> has been deprecated in favour of | ||
| the <link linkend="object.unserialize">__unserialize()</link> magic method. | ||
| <!-- RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_sleep_and_wakeup_magic_methods --> | ||
| </simpara> |
There was a problem hiding this comment.
I don't remember if this wasn't reverted with the soft deprecation RFC, so this would need to be removed.
| The <constant>MHASH_<replaceable>*</replaceable></constant> constants | ||
| have been deprecated. These have been overlooked when the mhash*() function | ||
| family has been deprecated per | ||
| <!-- RFC: https://wiki.php.net/rfc/deprecations_php_8_1#mhash_function_family --> |
There was a problem hiding this comment.
This text doesn't make much sense as the RFC which is being linked to is in a comment
There was a problem hiding this comment.
ok. deleted mhash*() related description in dc23d16.
| The <link linkend="language.oop5.cloning">clone language construct</link> | ||
| is now a function and supports reassigning (readonly) properties during | ||
| cloning via the new <property>$withProperties</property> parameter. | ||
| <!-- RFC: https://wiki.php.net/rfc/clone_with_v2 --> |
There was a problem hiding this comment.
@TimWolla it cannot be disabled via disable_functions right?
Girgias
left a comment
There was a problem hiding this comment.
Thank you for starting this! I left a lot of comments that I would like to have addressed. :)
Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
Thanks for all the feedback! I've addressed the points you raised, but I'm not sure how to fix the following. |
Girgias
left a comment
There was a problem hiding this comment.
More review comments, not sure I correctly identified the review comment you had issues with as the GitHub UI doesn't work...
| <simpara> | ||
| <function>pg_connect</function> checks if the connection_string argument | ||
| contains any null byte. | ||
| </simpara> | ||
|
|
||
| <simpara> | ||
| <function>pg_close_stmt</function> checks if the statement_name argument | ||
| contains any null byte. | ||
| </simpara> |
There was a problem hiding this comment.
Right so this should be move to the incompatible.xml file as this is a BC change and many of the other value errors are situated there
| <simpara> | ||
| Upgraded pcre2lib from 10.44 to 10.46. | ||
| </simpara> |
There was a problem hiding this comment.
This was downgraded again due to a bug in PCRE, @ndossche please confirm.
Co-authored-by: Gina Peter Banyard <girgias@php.net>
|
@Girgias ok, nits markup issues addressed again. Also, [ValueError|TypeError|Error|Exception] BC break changes are moved in 35ce39c, fed7a9f refs: https://github.com/php/doc-en/pull/4906/files#r2473529673 |
Girgias
left a comment
There was a problem hiding this comment.
Sorry for the delay haven't been feeling well.
Lets just merge this now and do more improvements over time.
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Based on PHP 8.5 UPGRADE NOTES and past migration guides.