Fix 11 pgsql function signatures to match php-src stubs#5355
Open
lacatoire wants to merge 1 commit intophp:masterfrom
Open
Fix 11 pgsql function signatures to match php-src stubs#5355lacatoire wants to merge 1 commit intophp:masterfrom
lacatoire wants to merge 1 commit intophp:masterfrom
Conversation
Return type fixes: - pg_escape_identifier: false|string -> string, param $data -> $string - pg_escape_literal: false|string -> string, param $data -> $string - pg_parameter_status: false|string -> string, param name fixes - pg_set_error_verbosity: false|int -> int Parameter name fixes: - pg_escape_bytea: $data -> $string - pg_escape_string: $data -> $string - pg_execute: $stmtname -> $statement_name - pg_prepare: $stmtname -> $statement_name - pg_lo_export: $pathname -> $filename - pg_lo_import: $pathname -> $filename, $object_id -> $oid - pg_put_line: $data -> $query
lacatoire
force-pushed
the
fix/pgsql-sync-src
branch
from
c4b96a2 to
9a1ee79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix return types and parameter names for 11 pgsql functions to match php-src stubs.
Return type fixes
pg_escape_identifier:false|string→string, param$data→$stringpg_escape_literal:false|string→string, param$data→$stringpg_parameter_status:false|string→string+ param name fixespg_set_error_verbosity:false|int→intParameter name fixes
pg_escape_bytea:$data→$stringpg_escape_string:$data→$stringpg_execute:$stmtname→$statement_namepg_prepare:$stmtname→$statement_namepg_lo_export:$pathname→$filenamepg_lo_import:$pathname→$filename,$object_id→$oidpg_put_line:$data→$queryReference