Fix GH-21027: strtotime() incorrectly parses decimal relative values #21034
+16,582
−13,996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21027
strtotime("2.37685 weeks")returned incorrect result (~414 million seconds instead of ~1.4 million) because:"2.37"matchedtimeshort24pattern (hour:minute with dot separator)"685 weeks"was parsed as separate relative offsetChanges
relnumberdecregex pattern for decimal numbersrelativedeclexer rule to match decimal relative expressionstimelib_get_decimal_nr()helper to parse decimal valuestimelib_set_relative_decimal()to convert decimal units to seconds