Fix opening browser on Linux by treating URL as 1 argument instead of many#5261
Merged
gautamdsheth merged 1 commit intopnp:devfrom Mar 7, 2026
Merged
Conversation
Collaborator
|
Thanks @NoelTautges , merged it ! Will be available starting with tomorrow's nightly builds. Awesome to have you contributing 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
What is in this Pull Request ?
On Linux, PnP can fail to open a browser for authentication when running
Register-PnPEntraIDAppForInteractiveLoginand other similar commands. It tries a series of commands likexdg-openwith a single argument for the URL in order to open a browser. However, that URL may contain spaces.OpenLinuxBrowseris usingProcessStartInfowith the constructor that treats the string as all the arguments, meaning that any URLs with spaces get split apart and not opened by the tool. This PR fixes the issue by using theProcessStartInfoconstructor with a list of arguments, forcing it to treat any URL with spaces as only 1 argument.