Add mypy type stubs and configuration for cyprecice module #2#252
Open
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
Open
Add mypy type stubs and configuration for cyprecice module #2#252AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
Conversation
AdityaGupta716
force-pushed
the
add-mypy-type-hints
branch
from
12bc5da to
cdb9ecb
Compare
Contributor
Author
|
@IshaanDesai plz review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Added mypy support for the cyprecice Python bindings:
cyprecice/cyprecice.pyi- type stubs for all Participant methodscyprecice/__init__.pyi- stub entry point for mypy module resolutioncyprecice/py.typed- PEP 561 marker indicating typing supportmypy.ini- mypy configurationRunning
mypy precice/passes with no errors.Notes:
get_version_information()return type verified asbytesfrom existing testscommunicatorparameter typed asOptional[Any]as mpi4py type is not always available