Avoid returning a zero byte count and a nil error on a Read at the en…#9
Merged
scunningham merged 1 commit intoprequel-dev:mainfrom Jul 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the LZ4 reader could return a zero byte count with a nil error when reading at the end of a frame, which violates the io.Reader interface contract that requires returning io.EOF when no more data is available.
- Added logic to avoid returning (0, nil) at end of frame by looping back to read more data
- Added comprehensive test case to verify the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/pkg/rdr/rdr.go | Implements the fix by adding a loop check to avoid (0, nil) returns at end of frame |
| internal/test/rd_test.go | Adds test case TestReadEmptyEnd to verify the reader properly returns EOF instead of (0, nil) |
Comments suppressed due to low confidence (1)
internal/test/rd_test.go:328
- There's a grammatical error in the comment. 'would could a' should be 'would return a' or 'could return a'.
}
aleksmaus
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d of a frame.