Open
Conversation
fischeti
force-pushed
the
fischeti/filter-script
branch
6 times, most recently
from
0d4580e to
7930fa6
Compare
fischeti
force-pushed
the
fischeti/filter-script
branch
from
7930fa6 to
4967432
Compare
fischeti
force-pushed
the
fischeti/filter-script
branch
from
4967432 to
c36b891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script
Similar to the
picklecommand, thescriptcommand gains a new--topflag (can be specified multiple times), that will filter out all unreachable files from said top modules.bender-slangChanges resp. fixes the behaviour for duplicate defined symbols. The previous behaviour was actually wrong (also in the
picklecommand) because it was first-one-wins. Now it is last-one-wins which is also what all EDA tools do afaik.Further, it adds a slang diagnostic language whenever a module name already exists. The diagnostic is slang style and reuses slang infrastructure for this.
Tests
Integration tests
There are now integration tests for
script flistoutput to check for existence of files (or the lack thereof). The pickle repo test suite is extended for that with an example of a duplicate module definition.Real-world tests
Tested in cheshire for
vsimandvcstarget here, pipeline passes. Reduces file list from 670 to 444.Also tested in FlooNoc for
vcsandsynopsys(elaboration), where it even discovered a duplicate file in the bender manifest🤓TODOs
bender-slangonce approved